Include reasoning for awards - #9101
Conversation
|
I wouldn't include the reasoning on hover 
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9101 +/- ##
==========================================
+ Coverage 96.95% 96.99% +0.04%
==========================================
Files 36 36
Lines 3710 3732 +22
==========================================
+ Hits 3597 3620 +23
+ Misses 113 112 -1
🚀 New features to boost your workflow:
|
|
I don’t like the distinction (in both the XML and the code) between "new" and "legacy" award tags. This could be much simplified. If we expect the reasoning to just be a single line of text, why not do:
|
|
Alternatively, if we expect the reasoning to be potentially too long and unwieldy for an attribute, I would consider doing a one-time change to our schema to flip it around:
|
|
Mainly I was trying to make the code backward-compatible, but if you're fine with ditching that, I agree that a single tag structure is simpler. The explanations this were were all paragraphs, which seemed unwieldy to me for an attribute, even though it is cleaner in the XML. Does it make sense for the award name to be the attribute, and the explanation the text? <award name="Best Paper" />
<award name="ACL 2026 Test of Time">After long deliberation, this paper was chosen because...</award> |
Okay, looks like we had the same idea. I'll go with that approach. |
Anything that changes the XML schema will break backward-compatibility anyway. |
|
Also, the interface wouldn’t have to change, |
| }* | ||
| & element award { | ||
| attribute name { text }, | ||
| text |
There was a problem hiding this comment.
Would require a bit of refactoring to support this; how extensive do we expect the "reasoning" to be?
There was a problem hiding this comment.
I suggest we just support the paragraph of text we've currently encountered, at least for the moment.
There was a problem hiding this comment.
This would not allow any text formatting or linked URLs. Maybe it's not needed, just thought it could make conceptual sense.
Markup is also not supported for revision notes, but we see revision notes with line breaks for paragraphs or bulleted lists.
mbollmann
left a comment
mbollmann
left a comment
There was a problem hiding this comment.
Almost ready to merge unless we do want to add MarkupText for the reasoning; I’ll let you decide if that’s worth it.
| }* | ||
| & element award { | ||
| attribute name { text }, | ||
| text |
There was a problem hiding this comment.
Would require a bit of refactoring to support this; how extensive do we expect the "reasoning" to be?
3 participants
This PR adds the chair-provided reasoning for awards as an option. The schema is backwards-compatible but it requires changes to the library.